quilt3: Add CRC64NVME checksum support (Phase 1) #4626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic CRC64NVME support to allow loading packages with CRC64NVME checksums: - Add CRC64NVME_HASH_NAME constant - Add CRC64NVME to SUPPORTED_HASH_TYPES tuple - Update _verify_hash() to skip validation for CRC64NVME - Add test_crc64nvme_hash_type() to verify support Note: CRC64NVME validation is intentionally skipped as these checksums come from trusted S3 infrastructure. Full validation support with Python CRC64 implementation will be added in a future update. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4626 +/- ##
==========================================
+ Coverage 39.34% 39.36% +0.01%
==========================================
Files 892 892
Lines 37146 37161 +15
Branches 5979 6238 +259
==========================================
+ Hits 14616 14629 +13
+ Misses 22026 21262 -764
- Partials 504 1270 +766
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
|
Decision: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add basic CRC64NVME checksum type support to quilt3 client:
This allows quilt3 to load and work with packages containing CRC64NVME checksums.
Phase 1: Basic support only - validation is skipped for CRC64NVME checksums as they come from trusted S3 infrastructure.
Future work (Phase 2): Implement full CRC64NVME validation with Python CRC64 library, and enable CRC64NVME for uploads.
Testing
✅ Verified on CRC stack
Related: #4623 (py-shared), #4624 (s3hash), #4625 (pkgpush)
🤖 Generated with Claude Code