-
Notifications
You must be signed in to change notification settings - Fork 91
fix codecov upload for lambdas #4594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4594 +/- ##
==========================================
- Coverage 38.53% 36.09% -2.45%
==========================================
Files 870 851 -19
Lines 37141 35134 -2007
Branches 6145 5930 -215
==========================================
- Hits 14314 12681 -1633
- Misses 21571 21944 +373
+ Partials 1256 509 -747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
Added the missing --cov-report xml flag to the pytest command in the test-lambda job. This generates the XML coverage report file (coverage.xml) that the codecov/codecov-action@v5 requires to upload coverage data. Previously, coverage was being collected but not reported in the correct format for Codecov to process. This change aligns the lambda test job with the existing pattern used in the test-client job (line 92).
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The change is a simple one-line addition of a standard pytest flag that generates XML coverage reports. This flag is already used successfully in the
test-clientjob on line 92, demonstrating it's a proven pattern in this codebase. The change only affects coverage reporting, not test execution or application functionality. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/py-ci.yml | 5/5 | Added --cov-report xml flag to pytest command to generate XML coverage report for Codecov upload |
Sequence Diagram
sequenceDiagram
participant GHA as GitHub Actions
participant Pytest as pytest
participant FS as File System
participant Codecov as Codecov Action
GHA->>Pytest: Run pytest --cov=lambdas --cov-report xml
Pytest->>Pytest: Execute tests with coverage
Pytest->>Pytest: Generate coverage data
Pytest->>FS: Write coverage.xml
Pytest->>GHA: Tests complete
GHA->>Codecov: Trigger codecov-action@v5
Codecov->>FS: Read coverage.xml
Codecov->>Codecov: Upload coverage data
Codecov->>GHA: Upload complete
1 file reviewed, no comments
Description
TODO
optipngon any new PNGsbuild.pyfor new docstrings