Skip to content

Conversation

@sir-sigurd
Copy link
Member

Description

TODO

  • Unit tests
  • Security: Confirm that this change meets security best practices and does not violate the security model
  • Open and Embed: Confirm that this change doesn't break Open variant and Embed widget
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quilt.bio)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.09%. Comparing base (94b266f) to head (3ec9df5).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4594      +/-   ##
==========================================
- Coverage   38.53%   36.09%   -2.45%     
==========================================
  Files         870      851      -19     
  Lines       37141    35134    -2007     
  Branches     6145     5930     -215     
==========================================
- Hits        14314    12681    -1633     
- Misses      21571    21944     +373     
+ Partials     1256      509     -747     
Flag Coverage Δ
api-python 91.66% <ø> (-0.01%) ⬇️
catalog 21.26% <ø> (+1.29%) ⬆️
lambda ?
py-shared 97.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Added the missing --cov-report xml flag to the pytest command in the test-lambda job. This generates the XML coverage report file (coverage.xml) that the codecov/codecov-action@v5 requires to upload coverage data. Previously, coverage was being collected but not reported in the correct format for Codecov to process. This change aligns the lambda test job with the existing pattern used in the test-client job (line 92).

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple one-line addition of a standard pytest flag that generates XML coverage reports. This flag is already used successfully in the test-client job on line 92, demonstrating it's a proven pattern in this codebase. The change only affects coverage reporting, not test execution or application functionality.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/py-ci.yml 5/5 Added --cov-report xml flag to pytest command to generate XML coverage report for Codecov upload

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant Pytest as pytest
    participant FS as File System
    participant Codecov as Codecov Action

    GHA->>Pytest: Run pytest --cov=lambdas --cov-report xml
    Pytest->>Pytest: Execute tests with coverage
    Pytest->>Pytest: Generate coverage data
    Pytest->>FS: Write coverage.xml
    Pytest->>GHA: Tests complete
    GHA->>Codecov: Trigger codecov-action@v5
    Codecov->>FS: Read coverage.xml
    Codecov->>Codecov: Upload coverage data
    Codecov->>GHA: Upload complete
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@sir-sigurd sir-sigurd marked this pull request as draft October 14, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants