Skip to content

Commit

Permalink
doc: enable doctests (#156)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjrh authored Nov 20, 2023
1 parent 7a06aa6 commit 5d3d279
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 11 deletions.
44 changes: 44 additions & 0 deletions docs/howto.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,50 @@ on Python 3.11:

nox -s test-3.11 -- -k simple_search

## Doctests

[Doctests](https://docs.python.org/3/library/doctest.html) are automatically
enabled for all docstrings in the `tantivy` module. Here is a very basic
introduction. Consider the following hypothetical Rust `struct`:

```rust
/// Tantivy's Document is the object that can be indexed and then searched for.
///
/// Documents are fundamentally a collection of unordered tuples
/// (field_name, value). In this list, one field may appear more than once.
///
/// Example:
/// >>> doc = tantivy.Document()
/// >>> doc.add_text("title", "The Old Man and the Sea")
/// >>> doc.add_text("body", ("He was an old man who fished alone in a "
/// ... "skiff in the Gulf Stream and he had gone "
/// ... "eighty-four days now without taking a fish."))
/// >>> doc
/// Document(body=[He was an ],title=[The Old Ma])
///
#[pyclass(module = "tantivy")]
#[derive(Clone, Default, PartialEq)]
pub(crate) struct Document {
pub(crate) field_values: BTreeMap<String, Vec<Value>>,
}
```

When the tests are executed, pytest will automatically search all the docstrings
for `>>>` and `...` and execute the code in the docstring. The output of the
code is compared to the text that follows the code. If the output matches, the
test passes. If the output does not match, the test fails.

In the above example, a Tantivy document object is created, and then the
representation of the document is printed. This representation, and indeed any
output that manual typing would produce, is compared to the text that follows
and this is how doctests work.

Doctests are a great way to ensure that the documentation is accurate and up to
date, and doctests are therefore encouraged be present on every public
interface that users will interact with. However, doctest are not suitable
for coverage testing and other more advanced testing methods so you must
judge when to use them.

## Working on tantivy-py documentation

Please be aware that this documentation is structured using the [Diátaxis](https://diataxis.fr/) framework. In very simple terms, this framework will suggest the correct location for different kinds of documentation. Please make sure you gain a basic understanding of the goals of the framework before making large pull requests with new documentation.
Expand Down
12 changes: 12 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,15 @@ dev = [

[tool.maturin]
bindings = "pyo3"

[tool.pytest.ini_options]
# Set the durations option and doctest modules
# See https://docs.pytest.org/en/latest/usage.html#durations
addopts = "--doctest-modules --durations=10"
# Use the `--ignore-glob` setting to exclude the `noxfile.py` module from the doctests
# See https://docs.pytest.org/en/latest/reference.html#confval-ignore_glob
testpaths = [
"tests",
"tantivy",
"src",
]
24 changes: 13 additions & 11 deletions src/document.rs
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,10 @@ impl<'a> From<&'a Value> for BorrowedSerdeValue<'a> {
/// >>> doc = tantivy.Document()
/// >>> doc.add_text("title", "The Old Man and the Sea")
/// >>> doc.add_text("body", ("He was an old man who fished alone in a "
/// "skiff in the Gulf Stream and he had gone "
/// "eighty-four days now without taking a fish."))
/// ... "skiff in the Gulf Stream and he had gone "
/// ... "eighty-four days now without taking a fish."))
/// >>> doc
/// Document(body=[He was an ],title=[The Old Ma])
///
/// For simplicity, it is also possible to build a `Document` by passing the field
/// values directly as constructor arguments.
Expand All @@ -451,16 +453,16 @@ impl<'a> From<&'a Value> for BorrowedSerdeValue<'a> {
///
/// Example:
/// >>> schema = (
/// SchemaBuilder()
/// .add_unsigned_field("unsigned")
/// .add_integer_field("signed")
/// .add_float_field("float")
/// .build()
/// )
/// ... SchemaBuilder()
/// ... .add_unsigned_field("unsigned")
/// ... .add_integer_field("signed")
/// ... .add_float_field("float")
/// ... .build()
/// ... )
/// >>> doc = tantivy.Document.from_dict(
/// {"unsigned": 1000, "signed": -5, "float": 0.4},
/// schema,
/// )
/// ... {"unsigned": 1000, "signed": -5, "float": 0.4},
/// ... schema,
/// ... )
#[pyclass(module = "tantivy")]
#[derive(Clone, Default, PartialEq)]
pub(crate) struct Document {
Expand Down

0 comments on commit 5d3d279

Please sign in to comment.