Add support for num_crops and valid_size from vLLM#796
Open
quic-vargupt wants to merge 1 commit intoquic:mainfrom
Open
Add support for num_crops and valid_size from vLLM#796quic-vargupt wants to merge 1 commit intoquic:mainfrom
quic-vargupt wants to merge 1 commit intoquic:mainfrom
Conversation
quic-vargupt
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: Varun Gupta <vargupt@qti.qualcomm.com>
quic-vargupt
force-pushed
the
molmo_vllm_epd_fix
branch
from
88cdf14 to
f6281ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR add support for
num_cropsandvalid_sizefrom vLLM in override configs in case of E-PD.