handle knit_asis output correctly without wrapping cell divs #12024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With knitr 1.49, using sew.knit_asis correctly pass modified options$results = "asis" to output hooks for consideration. However, quarto checks for options$results == "asis" in more places and knitr does not modified the cell option outside of output hook context. So we need quarto to save the step from output hook context to be reused through the rest of chunk hook processing. This change correctly make asis_output() results don't have unnecessary cell div
cderv
force-pushed
the
knitr/asis_output
branch
from
f267a9c to
40ae02c
Compare
…ell div like if html-table-processing none has been set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9184 and fixes #9185
This PR introduces a hack to work with the new behavior of knitr 1.49 that helps by passing
options$results = "asis"to output hook context.However, quarto does check for
options$results == "asis"outside of this output hook context and knitr does not modify the option in the whole cell context. (This could be something done too yihui/knitr#2333)So to make the change in knitr solves the problem at quarto level, modified options needs to be saved for the remaining cell context handling (until chunk hook).
This PR do that by
Opening as draft to run our CI checks.