Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/11860 #11862

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Bugfix/11860 #11862

merged 3 commits into from
Jan 14, 2025

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Jan 14, 2025

Closes #11860. This implements the "dynamic" solution for the bug, where we now bundle linked ES6 modules with esbuild and replace them with data URLs. This is a more comprehensive solution than Pandoc's, which stops at the first include, breaking ES6 scripts that have import statements in them.

cc @cderv :D

@cscheid cscheid merged commit 182adf7 into main Jan 14, 2025
47 checks passed
@cscheid cscheid deleted the bugfix/11860 branch January 14, 2025 21:48
@cderv
Copy link
Collaborator

cderv commented Jan 15, 2025

🎉 🚀 I had no doubt !

I was quite sure we wouldn't need the automation on CI for static solution - It is hard to share clearly some thoughts by written github comments sometimes 😅 - Sorry is was unclear. 😉

Thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embed-resources needs to work with es6 modules
2 participants