Skip to content

Commit

Permalink
adapt revealjs chalkboard for next update
Browse files Browse the repository at this point in the history
Upstream PR has been merged and new commit on main can be used now.
  • Loading branch information
cderv committed Jan 16, 2025
1 parent 502ec16 commit ba355e1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 25 deletions.
5 changes: 3 additions & 2 deletions configuration
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ export TIPPY_JS=6.3.7
export PDF_JS=2.8.335
export REVEAL_JS=5.1.0
export REVEAL_JS_MENU=2.1.0
# unrelease version needed for a fix with Reveal.js 5
# unrelease version needed for fixes with Reveal.js 5
# https://github.com/rajgoel/reveal.js-plugins/pull/180
export REVEAL_JS_CHALKBOARD=8408d5a265abf74a042122520bbb4fd0d31feaed
# https://github.com/rajgoel/reveal.js-plugins/pull/184
export REVEAL_JS_CHALKBOARD=217142176341e24628db2908cae38221ef13d639
export REVEAL_JS_PDFEXPORT=2.0.1
export LIST_JS=2.3.1
export DAY_JS=1.11.7
Expand Down

This file was deleted.

7 changes: 1 addition & 6 deletions package/src/common/update-html-dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,6 @@ export async function updateHtmlDependencies(config: Configuration) {
},
true, // true if commit, false otherwise
false, // no v prefix,
// FIXME: Patch waiting for fix upstream to be merged
// https://github.com/rajgoel/reveal.js-plugins/pull/184
resolvePatches([
"revealjs-plugin-0001-chakboard-backdrop-filter.patch"
])
);

// revealjs-menu
Expand Down Expand Up @@ -1128,7 +1123,7 @@ async function updateGithubSourceCodeDependency(
await unzip(zipFile, working);

await onDownload(working, version);
if (patches) applyGitPatches(patches);
if (patches) await applyGitPatches(patches);
} else {
throw new Error(`${versionEnvVar} is not defined`);
}
Expand Down
3 changes: 1 addition & 2 deletions src/resources/formats/revealjs/plugins/chalkboard/plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,7 @@ const initChalkboard = function ( Reveal ) {
container.style.visibility = 'visible';
container.style.pointerEvents = 'none';
container.style['backdrop-filter'] = 'none';
// for older safari
container.style["-webkit-backdrop-filter"] = "none";
container.style['-webkit-backdrop-filter'] = 'none';

var slides = document.querySelector( '.slides' );
var aspectRatio = Reveal.getConfig().width / Reveal.getConfig().height;
Expand Down

0 comments on commit ba355e1

Please sign in to comment.