Center cf logo in footer, vertically #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
holly-cummins
force-pushed
the
improve-cf-logo-alignment
branch
from
2286c17 to
d3343e7
Compare
|
I have no idea why the PR preview is unavailable :( Edit: Rebased, and it's there now, but a bad rebase wrecked it all, so fixed that too. |
holly-cummins
force-pushed
the
improve-cf-logo-alignment
branch
from
d3343e7 to
2ee57e7
Compare
holly-cummins
force-pushed
the
improve-cf-logo-alignment
branch
from
2ee57e7 to
b2bec2c
Compare
holly-cummins
force-pushed
the
improve-cf-logo-alignment
branch
from
b2bec2c to
5519a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
I think the main thing that made a difference was scattering
display:flexinto the anchors wrapping the images. I also switched from spans to divs, since I think that's closer to what's wanted, semantically, and also used thegapfeature of flexbox instead of padding the individual containers asymmetrically.