Reapply "Switch Vert.x HTTP to @ConfigMapping" #45274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f90f04. This was originally written by Roberto, it conflicted all around with all the new changes that got in so it was a lot of fun rebasing :) Co-authored-by: Roberto Cortez <[email protected]>
|
🎊 PR Preview 4f943d5 has been successfully built and deployed to https://quarkus-pr-main-45274-preview.surge.sh/version/main/guides/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f90f04 and reapply the
Switch Vert.x HTTP to @ConfigMappingchange.This was originally written by Roberto, it conflicted all around with all the new changes that got in so it was a lot of fun rebasing :)
@radcortez I don't know if you remember but this change broke quite a lot of extensions out there. I wonder if we should apply the same trick and have the interface with a new name and keep the old config as deprecated with maybe only the ports? I think if we keep the compatibility for the ports, we fix 99% of the breaking change. We might need to add a few more such as
rootPathbut I would rather be conservative and get the feedback from Ecosystem CI first.Note that I will have a look at the consequences of this change this afternoon so that we hopefully don't have to revert later.