Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataMapping annotation and new configuration #34

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Jul 2, 2024

Fixes #19

@mcruzdev mcruzdev force-pushed the issue-19 branch 2 times, most recently from e9046b3 to a84021d Compare July 3, 2024 18:34
@mcruzdev
Copy link
Member Author

mcruzdev commented Jul 3, 2024

I will squash it after because I mentioned a commit in Zulip.

.done());
} else if (roqDataMapping.getData() instanceof JsonArray array) {

if (roqDataMapping.isRecord()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ia3andy ia3andy requested a review from melloware July 12, 2024 09:09
@ia3andy
Copy link
Contributor

ia3andy commented Jul 12, 2024

@mcruzdev is it ready for review?

@mcruzdev
Copy link
Member Author

mcruzdev commented Jul 12, 2024

@mcruzdev is it ready for review?

Hi @ia3andy, I stopped because we need definition about how the user will use the data mapping feature.

I do not know if we will use an intermediate type or simply a List<>

@mcruzdev
Copy link
Member Author

mcruzdev commented Jul 19, 2024

sorry @ia3andy @melloware I'm still on vacation. But now we can use parent mapping.

I think you can take a initial looking.

@mcruzdev mcruzdev marked this pull request as ready for review July 22, 2024 04:50
@mcruzdev mcruzdev requested a review from a team as a code owner July 22, 2024 04:50
@ia3andy
Copy link
Contributor

ia3andy commented Jul 22, 2024

I will give it a try today

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!!! Thanks @mcruzdev you roq!

I am getting ClassNotFound exception on a trial local project. I think you need to use Jandex to locate the class:
https://quarkus.io/guides/writing-extensions#scanning-deployments-using-jandex

Could you also add the doc section about data (just add a new page with an index like we do on web-bundler or quinoa, we'll add the rest of the content late)? -- if we don't start it it will be too much to catch up..

@ia3andy
Copy link
Contributor

ia3andy commented Jul 22, 2024

image

@ia3andy ia3andy merged commit 5201330 into quarkiverse:main Jul 24, 2024
1 check passed
@ia3andy
Copy link
Contributor

ia3andy commented Jul 24, 2024

@mcruzdev add the doc in another PR ;-)

@mcruzdev mcruzdev self-assigned this Jul 31, 2024
mcruzdev pushed a commit that referenced this pull request Oct 9, 2024
Add DataMapping annotation and new configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[roq-data] Generated bindings to data file
3 participants