Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #26

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Refactor #26

merged 1 commit into from
Jun 27, 2024

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jun 27, 2024

No description provided.

@ia3andy ia3andy requested a review from a team as a code owner June 27, 2024 09:31
melloware
melloware approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we should have done something similar in Quinoa with a BuildItem then?

@ia3andy ia3andy merged commit 08a59e7 into quarkiverse:main Jun 27, 2024
1 check passed
@ia3andy ia3andy deleted the refactor branch June 27, 2024 12:38
@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 27, 2024

@melloware now we should use this BuildItem in the roq-data

@melloware
Copy link
Contributor

so use that new build item combined with roq-data 's config for data location to create the proper path?

@ia3andy
Copy link
Contributor Author

ia3andy commented Jun 27, 2024

@melloware you go for it? and maybe start #18

mcruzdev pushed a commit that referenced this pull request Oct 9, 2024
@ia3andy
Merge pull request #26 from ia3andy/refactor
42d586b 
Refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ia3andy @melloware