Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the success message as some opensource models like empower-fun… #617

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

change the success message as some opensource models like empower-fun… #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da210a2
change the success message as some opensource models like empower-fun…
MoheyEl-DinBadr May 22, 2024
72354c2
Update ToolProcessor.java
MoheyEl-DinBadr May 25, 2024
4a5aad9
Update QuarkusToolExecutor.java
MoheyEl-DinBadr May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/deployment/src/main/java/io/quarkiverse/langchain4j/deployment/ToolProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ private static String generateInvoker(MethodInfo methodInfo, ClassOutput classOu

boolean toolReturnsVoid = methodInfo.returnType().kind() == Type.Kind.VOID;
if (toolReturnsVoid) {
invokeMc.returnValue(invokeMc.load("Success"));
invokeMc.returnValue(invokeMc.load("\"Success\""));
} else {
invokeMc.returnValue(result);
}
Expand Down
2 changes: 1 addition & 1 deletion core/runtime/src/main/java/io/quarkiverse/langchain4j/runtime/tool/QuarkusToolExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public String execute(ToolExecutionRequest toolExecutionRequest, Object memoryId

private static String handleResult(ToolInvoker invokerInstance, Object invocationResult) {
if (invokerInstance.methodMetadata().isReturnsVoid()) {
return "Success";
return "\"Success\"";
}
return Json.toJson(invocationResult);
}
Expand Down
Loading