Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with api-key for open-ai to have a default of empty and val… #616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MoheyEl-DinBadr
Copy link

…idate if the default base url is used then the api key must be provided

…idate if the default base url is used then the api key must be provided
@MoheyEl-DinBadr MoheyEl-DinBadr requested a review from a team as a code owner May 22, 2024 23:20
@geoand
Copy link
Collaborator

geoand commented May 23, 2024

I am pretty sure this does not work properly in the case where multiple named configurations exist.

What is the use case you are trying to fix? It's not clear to me what your end goal is with this change.

@MoheyEl-DinBadr
Copy link
Author

I have tested it with the default and a named configuration named test and both worked just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants