Migrate to the JsonSchemaElement API #1100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure I got everything! Let's make sure CI passes |
edeandrea
commented
Nov 22, 2024
|
|
||
| // Using ConcurrentHashMap in case multiple threads are using this class at the same time | ||
| // Not sure if this will ever happen | ||
| private final Map<Class<?>, JsonSchemaElementObjectSubstitution> substitutions = new ConcurrentHashMap<>(8); |
There was a problem hiding this comment.
@geoand I'm not too familiar with substitutions/etc. I wasn't sure if there was any kind of a chance of multi-threading here, so I used a ConcurrentHashMap.
If there's no chance of multiple threads calling this at the same time I can switch it to a HashMap.
edeandrea
force-pushed
the
migrate-to-JsonSchemaElement
branch
from
0c407f7
to
0dd1268
Compare
Status for workflow
|
|
Ops, I'm starting to work on the same topic. You can see the changes in my repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to the
JsonSchemaElementAPI.Closes #1054