Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the JsonSchemaElement API #1100

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Migrate to the JsonSchemaElement API #1100

merged 1 commit into from
Nov 25, 2024

Conversation

edeandrea
Copy link
Collaborator

Migrate to the JsonSchemaElement API.

Closes #1054

@edeandrea edeandrea marked this pull request as ready for review November 22, 2024 21:10
@edeandrea edeandrea requested a review from a team as a code owner November 22, 2024 21:10
@edeandrea
Copy link
Collaborator Author

I'm pretty sure I got everything! Let's make sure CI passes

@edeandrea edeandrea force-pushed the migrate-to-JsonSchemaElement branch from 0c407f7 to 0dd1268 Compare November 22, 2024 21:44
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@andreadimaio
Copy link
Collaborator

andreadimaio commented Nov 23, 2024 •
edited
Loading

Ops, I'm starting to work on the same topic. You can see the changes in my repo.

@edeandrea
Copy link
Collaborator Author

edeandrea commented Nov 24, 2024 •
edited
Loading

I'm sorry about crossing each other. There was already an issue I had created a few weeks ago (#1054) that I had assigned to myself.

I started working on this a few weeks ago but then ran into a wall and needed to wait for a LangChain4j upgrade (#1075).

@andreadimaio
Copy link
Collaborator

Yeah, I noticed it after I started. I wasn't paying attention 😄 .

@edeandrea
Copy link
Collaborator Author

From what I can tell (only looking at this on my phone) we came up with similar solutions :)

Good sanity check!

@geoand
Copy link
Collaborator

geoand commented Nov 25, 2024

Very nice, thanks @edeandrea! I added a small comment on this

@edeandrea edeandrea force-pushed the migrate-to-JsonSchemaElement branch from 2ae7fb0 to 23bf2a8 Compare November 25, 2024 13:20
@edeandrea edeandrea force-pushed the migrate-to-JsonSchemaElement branch from 83172f3 to 37ccdf2 Compare November 25, 2024 13:23
geoand
geoand approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@geoand
Copy link
Collaborator

geoand commented Nov 25, 2024

Once this is in, I'll release a 0.22.0.CR1

@geoand geoand merged commit 71e0996 into quarkiverse:main Nov 25, 2024
64 checks passed
@edeandrea edeandrea deleted the migrate-to-JsonSchemaElement branch November 25, 2024 13:43
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 25, 2024

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 37ccdf2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadimaio andreadimaio andreadimaio left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to the JsonSchemaElement API
3 participants
@edeandrea @andreadimaio @geoand