Upgrade to LangChain4j 0.36.2 #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmartisk
commented
Nov 22, 2024
•
jmartisk
commented
- Closes: Update to LangChain4j 0.36 #1075
jmartisk
commented
Nov 22, 2024
| @@ -1,7 +1,5 @@ | |||
| package io.quarkiverse.langchain4j.runtime.aiservice; | |||
|
|
|||
| import static org.apache.commons.lang3.StringUtils.EMPTY; | |||
There was a problem hiding this comment.
This dependency has somehow disappeared, but I don't see why we should re-add it just for a constant of an empty string
This comment has been minimized.
This comment has been minimized.
jmartisk
force-pushed
the
lc4j-0.36.2
branch
from
b459454
to
3168cce
Compare
Status for workflow
|
geoand
reviewed
Nov 22, 2024
| @@ -116,6 +118,12 @@ public MistralAiEmbeddingResponse embedding(MistralAiEmbeddingRequest request) { | |||
| return restApi.embedding(request, apiKey); | |||
| } | |||
|
|
|||
| // TODO: we don't provide support for MistralAiModerationModel yet | |||
There was a problem hiding this comment.
Well, users can instantiate it directly, but we don't have a declarative way via config properties for it yet. I plan to add that via #1095
geoand
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.