-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Secure SQL ChatBot demo #1073
Conversation
Gonna try to run it today |
Very cool @sberyozkin! |
4fe0077
to
46be75c
Compare
@geoand @jmartisk I've added a custom WebSockets ticket scheme just to show what users can do to make what are already secure WSS upgrade requests even more secure, and updated README with a a more complete list of security considerations. Next, I'll to tune some of the RAG code to take the user identity into account and the demo should be ready for review once it is done |
fd5f73b
to
42ef0d8
Compare
@jmartisk Jan, I did something similar to what is done in the secure fraud detection demo. So, in addition to the Movies data support which was already available, a Then, the Movie content retriever passes the genre preferred by the current user to the MovieSupport AI service which is asked to use this property to sort the movies... Hopefully it is good enough to show how AI can use the user identity to support its work :-), have a look please Thanks |
Also added a Logout support, missing movie watcher exception support, similarly to how it is done in the secure fraud detection demo... I'm happy enough now with what this demo can show... |
This comment has been minimized.
This comment has been minimized.
...re-sql-chatbot/src/main/java/io/quarkiverse/langchain4j/sample/chatbot/MovieMuseSupport.java
Outdated
Show resolved
Hide resolved
...-chatbot/src/main/java/io/quarkiverse/langchain4j/sample/chatbot/MovieWatcherRepository.java
Show resolved
Hide resolved
...re-sql-chatbot/src/main/java/io/quarkiverse/langchain4j/sample/chatbot/MovieMuseSupport.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
f7fd5e6
to
bb9d706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
@jmartisk Let me do a bit of formatting as I've reset the workspace and lost the formatting configuration, so a few sources have tabs impacting them. And a few typos in README |
bb9d706
to
9c213bb
Compare
Should be better now... |
9c213bb
to
62c0836
Compare
Status for workflow
|
Fixes #609.
The flow will look like this:
ContentRetriever
can only be called if the user is authenticated:I'd just like to look at some hardening updates at the Quarkus level with Martin and Michal to have some more security binding done, but overall it is looking not bad with the WS-Next security support.
Here are application.properties.
It is only
HTTPS
andWSS
secure protocols.I'll look at adding a custom WS Next
HttpUpgradeCheck
.Perhaps an output Quardrail can be added as well
CC @geoand @cescoffier