Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the JsonSchemaElement API #1054

Open
edeandrea opened this issue Nov 5, 2024 · 6 comments · May be fixed by #1100
Open

Migrate to the JsonSchemaElement API #1054

edeandrea opened this issue Nov 5, 2024 · 6 comments · May be fixed by #1100
Assignees
@edeandrea
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements

Comments

@edeandrea
Copy link
Collaborator

When defining tools, use the new JsonSchemaElement API instead of JsonSchemaProperty.

See #1036 (comment) for some details. This needs to be put on hold a bit until the next upstream LangChain4j release, as it contains some things that are needed.
@edeandrea edeandrea self-assigned this Nov 5, 2024
@edeandrea
Copy link
Collaborator Author

I've already started work on this and have some things stashed, so once the next LangChain4j release is out and taken by the extension then I can complete this work.

@edeandrea edeandrea mentioned this issue Nov 5, 2024
Open
@geoand
Copy link
Collaborator

geoand commented Nov 6, 2024

🙏🏽

@geoand geoand added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Nov 11, 2024
@edeandrea
Copy link
Collaborator Author

I will take this up now that #1075 has been done.

@geoand
Copy link
Collaborator

geoand commented Nov 22, 2024

Now is the time :)

@edeandrea
Copy link
Collaborator Author

I'll try to get to this next week

@geoand
Copy link
Collaborator

geoand commented Nov 22, 2024

🙏🏽

edeandrea added a commit to edeandrea/quarkus-langchain4j that referenced this issue Nov 22, 2024
@edeandrea
Migrate to the JsonSchemaElement API
05e3d8c 
Closes quarkiverse#1054
@edeandrea edeandrea linked a pull request Nov 22, 2024 that will close this issue
Open
edeandrea added a commit to edeandrea/quarkus-langchain4j that referenced this issue Nov 22, 2024
@edeandrea
Migrate to the JsonSchemaElement API
0c407f7 
Closes quarkiverse#1054
edeandrea added a commit to edeandrea/quarkus-langchain4j that referenced this issue Nov 22, 2024
@edeandrea
Migrate to the JsonSchemaElement API
0dd1268 
Closes quarkiverse#1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edeandrea edeandrea

Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to the JsonSchemaElement API edeandrea/quarkus-langchain4j
2 participants
@edeandrea @geoand