Add a new sweep metadata from/to proto approach #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BichengYing
requested review from
wcourtney,
vtomole,
verult and
a team
as code owners
BichengYing
requested review from
maffoo,
NoureldinYosri,
senecameeks and
dstrain115
senecameeks
reviewed
Jan 10, 2025
| ) | ||
| return Metadata( | ||
| device_parameters=device_parameters or None, | ||
| label=metadata.label if metadata.HasField("label") else None, |
There was a problem hiding this comment.
by default protobuf will return the empty string if the label field was not populated, which is falsy and will act the same as passing None to an Optional[str] . So I don't think you need else None here
Same for param.idx above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #6869
This PR added a new path to encode and decode metadata to this corresponding proto. Notice this is a side path if the metadata in sweep is not encoded as
Metadataclass, the code path is still old and same forfrom_protocase. If the proto does not containmetadataproto field, the code still convert back as the old style