Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve __str__ and __repr__ for SingleQubitCliffordGate (issue #6326) #6920

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Improve __str__ and __repr__ for SingleQubitCliffordGate (issue #6326) #6920

merged 6 commits into from
Jan 15, 2025

Conversation

codrut3
Copy link
Contributor

@codrut3 codrut3 commented Jan 4, 2025 •
edited by dstrain115
Loading

Change repr to be simpler following the recommendation in the issue description.

Fixes: #6326

@codrut3 codrut3 requested review from vtomole and a team as code owners January 4, 2025 20:50
@codrut3 codrut3 requested a review from mhucka January 4, 2025 20:50
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 4, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (0361a81) to head (09e29df).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6920   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files        1084     1084           
  Lines       94420    94427    +7     
=======================================
+ Hits        92409    92417    +8     
+ Misses       2011     2010    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codrut3 added 2 commits January 8, 2025 19:52
@codrut3
Improve __str__ and __repr__ for SingleQubitCliffordGate (issue quant…
1b79cfa 
…umlib#6326)

Change __repr__ to be simpler following the recommendation in the issue description.
@codrut3
Merge branch 'main' into issue-6326
fbcb99c
dstrain115
dstrain115 reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the issue to the PR? Otherwise, LGTM. Will approve once I can compare to the request issue.

@dstrain115 dstrain115 enabled auto-merge (squash) January 14, 2025 03:08
dstrain115
dstrain115 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm, I see it's in the title. Approved.

auto-merge was automatically disabled January 15, 2025 15:18

Pull Request is not mergeable

auto-merge was automatically disabled January 15, 2025 15:18

Pull Request is not mergeable

@dstrain115 dstrain115 merged commit 2949afd into quantumlib:main Jan 15, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@mhucka mhucka Awaiting requested review from mhucka mhucka is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve __str__ and __repr__ for SingleQubitCliffordGate
3 participants
@codrut3 @dstrain115 @CirqBot