Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 Type Compatibility #643

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

mrginglymus
Copy link
Contributor

In order to support storybookjs/storybook#30031, widen return types that were the now removed ReactChild to ReactNode. Ideally they would have been narrowed, to something more specific, but that would have broken type compatibility with existing users.

I've also added the necessary lines to stop unexpected cache churn for windows devs. We are out there!

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: e8ff4b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
markdown-to-jsx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks :)

@quantizor quantizor merged commit 52a727c into quantizor:main Dec 18, 2024
6 checks passed
@mrginglymus mrginglymus deleted the r19-type-compat branch December 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants