Add space between ( and the binary in LIT tests#746
Open
Ris-Bali wants to merge 1 commit intoqualcomm:mainfrom
Open
Add space between ( and the binary in LIT tests#746Ris-Bali wants to merge 1 commit intoqualcomm:mainfrom
( and the binary in LIT tests#746Ris-Bali wants to merge 1 commit intoqualcomm:mainfrom
Conversation
partaror
reviewed
Jan 27, 2026
| ### because it crashes only in some code paths when doing LTO. | ||
|
|
||
| RUN: %clang %clangopts -c %p/Inputs/1.c -O2 -ffunction-sections -flto -o %t1.o | ||
| RUN: (%not %link %linkopts --save-temps %t1.o -o %t1.out 2>&1 || true) | %filecheck %s |
Member
There was a problem hiding this comment.
The braces does not seem stray / without-any-purpose. For the windows issue, would adding a space between the brace ( and the lit substitution variable %not be enough?
Contributor
There was a problem hiding this comment.
Remove || true. I dont think its needed.
Ris-Bali
force-pushed
the
windows_trailing_character
branch
from
5b1220b to
840effc
Compare
Ris-Bali
changed the title
() from eld tests( and the binary in LIT tests
Ris-Bali
force-pushed
the
windows_trailing_character
branch
from
840effc to
50a91e8
Compare
This patch adds a trailing space between the `(` and the binary in commands for some tests. Signed-off-by: Rishabh Bali <rbali@qti.qualcomm.com>
Ris-Bali
force-pushed
the
windows_trailing_character
branch
from
50a91e8 to
4463b6d
Compare
Contributor
|
Please add a reference to a failing build and copy the error here. |
quic-akaryaki
requested changes
Jan 30, 2026
Contributor
quic-akaryaki
left a comment
quic-akaryaki
left a comment
There was a problem hiding this comment.
Please describe the error that happens on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds space between the
(and the binary in some commands in LIT tests. These have been causing failures in specific windows environments.The error occuring is
'(i:/bld/llvm/bin/not.exe': command not found