Fix Relaxation/UnalignedCrash/UnalignedCrash.test#364
Open
parth-07 wants to merge 2 commits intoqualcomm:mainfrom
Open
Fix Relaxation/UnalignedCrash/UnalignedCrash.test#364parth-07 wants to merge 2 commits intoqualcomm:mainfrom
parth-07 wants to merge 2 commits intoqualcomm:mainfrom
Conversation
This commit fixes the test RISCV/standalone/Relaxation/UnalignedCrash/UnalignedCrash.test. The test checks that the link command fails with the insufficient bytes for alignment relaxation error. However, for this test, the link should pass without any errors. It was currently erroring out because of the incorrect fragment address. This commit fixes the test so that the link should fail with the insufficient bytes for alignment relaxation error without relying on the incorrect fragment address. Resolves qualcomm#363 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
InsufficientAlignmentRelaxation
branch
from
4e8b508 to
3bf80d3
Compare
Contributor
Author
|
LLVM mc used to generate incorrect (error-prone?) alignment padding when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the test
RISCV/standalone/Relaxation/UnalignedCrash/UnalignedCrash.test. The test checks that the link command fails with the insufficient bytes for alignment relaxation error. However, for this test, the link should pass without any errors. It was currently erroring out because of the incorrect fragment address. This commit fixes the test so that the link should fail with the insufficient bytes for alignment relaxation error without relying on the incorrect fragment address.
Resolves #363