Update GitHub Actions #899
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 99 99
Lines 17765 17765
=======================================
Hits 15726 15726
Misses 2039 2039 ☔ View full report in Codecov by Sentry. |
| { | ||
| "buildCommand": "cd quadratic-client && npm run build:ci", | ||
| "installCommand": "cd quadratic-client && npm install" | ||
| } |
There was a problem hiding this comment.
Pretty sure this is unused as it is defined in the vercel ui
| @@ -83,6 +83,8 @@ harness = false | |||
| # Tell `rustc` to optimize for small code size. | |||
| opt-level = "s" | |||
|
|
|||
| [package.metadata.wasm-pack.profile.release] | |||
| wasm-opt = ['-Os', '-g'] # TODO: -g seems to fix the name mangling problem | |||
There was a problem hiding this comment.
| @@ -13,7 +13,7 @@ | |||
| "lint:prettier:write": "prettier --write \"src/**/*.ts\"", | |||
| "prisma:migrate": "npx prisma migrate dev", | |||
| "prisma:migrate:create": "npx prisma migrate dev --create-only", | |||
| "docker:up": "docker-compose up -d && sleep 1", | |||
| "docker:up": "docker-compose up -d && sleep 3", | |||
There was a problem hiding this comment.
Curious, what's the need for this sleep?
There was a problem hiding this comment.
It takes a sec for Postgres to be available. Commands that actually wait for Postgres to be up are really complicated. This works 🤷♂️
| @@ -11,7 +11,8 @@ frontend: | |||
|
|
|||
| build: | |||
| commands: | |||
| - npm run build:wasm | |||
There was a problem hiding this comment.
Is this already built in GHA?
There was a problem hiding this comment.
Amplify is a separate pipeline
self-hostedis downWith our self-hosted runners all online tests run fast:
All our self-hosted runners are tagged
ubuntu-latest-8-coresif our self-hosted runners are not available or if more jobs are run than the eight available. GitHub will spin up hosted runners with the same tagubuntu-latest-8-cores.With our self-hosted runners all offline. Tests still pass but take longer:
This is the current speed of actions on
main