Merge Cells #2143
Open
Merge Cells #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidfig
commented
Dec 21, 2024
•
davidfig
commented
- intital sheet.merge_cells data structure
- ensure emerge cells don't intersect themselves
- ensure merge cells don't intersect with existing merge cells
- hide gridlines overlapping merge cells
- hashes should properly align against merged cell bounds
- unmerge cells
- merge cell menu (probably Menu > Format > Merge and palette)
- merge cell fills
- cursor should outline merge cells
- selection should always include entire merged cells--ie, a selection expands to include the width and height of merged cells that overlap the selection (this is how Excel/Sheets handle it)
- serialize merge cells with sheet
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.