Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1892 from quadratichq/qa #1913

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Merge pull request #1892 from quadratichq/qa #1913

merged 1 commit into from
Sep 24, 2024

Conversation

davidkircos
Copy link
Collaborator

QA: Sept 19

Copy link

qa-wolf bot commented Sep 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic 🔄 Building (Inspect) Visit Preview Sep 24, 2024 4:00pm

@davidkircos davidkircos merged commit 4918f08 into qa Sep 24, 2024
13 of 14 checks passed
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1913 September 24, 2024 16:03 Inactive
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (207fca6) to head (c45265b).
Report is 2 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1913   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         220      220           
  Lines       46968    46968           
=======================================
  Hits        42796    42796           
  Misses       4172     4172           
Flag Coverage Δ
91.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

qa-wolf bot commented Sep 24, 2024

E2E tests

Ran Status Preview Started
70 workflows In review (Details) Sep 24, 2024 at 4:31 PM (UTC)
⚠️ 43 failed - your wolf pack is investigating
✅ 23 passed

Preexisting bugs

0 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant