Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formulas fix to QA #1717

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Add Formulas fix to QA #1717

merged 2 commits into from
Aug 15, 2024

Conversation

davidkircos
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Aug 15, 2024

E2E tests

QA No blocking bugs

Ran Status Preview Started Run time Est. dev time saved
68 workflows Done (Details) Aug 15, 2024 at 10:39 PM (UTC) 21 minutes ~27.83 hrs
✅ 67 passed

Preexisting bugs

0 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

. . . . . . . .

Re-run your E2E tests

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic 🔄 Building (Inspect) Visit Preview Aug 15, 2024 10:08pm

@cla-bot cla-bot bot added the cla-signed label Aug 15, 2024
@davidkircos davidkircos changed the title Main Add Formulas fix to QA Aug 15, 2024
@davidkircos davidkircos merged commit 1c296ec into qa Aug 15, 2024
19 of 20 checks passed
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1712 August 15, 2024 22:08 Inactive
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (7211292) to head (4b20aab).
Report is 18 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff            @@
##               qa    #1717    +/-   ##
========================================
  Coverage   90.62%   90.63%            
========================================
  Files         192      192            
  Lines       38439    38645   +206     
========================================
+ Hits        34836    35025   +189     
- Misses       3603     3620    +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants