Migrate test-app to glimmer components and newer ember syntax #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasgasco
reviewed
Oct 6, 2023
nicolasgasco
reviewed
Oct 6, 2023
nicolasgasco
approved these changes
Oct 6, 2023
vscav
reviewed
Oct 11, 2023
vscav
approved these changes
Oct 19, 2023
dannycalleri
approved these changes
Oct 23, 2023
m-jovan
force-pushed
the
migrate-testapp-glimmer
branch
from
05b442c to
7938f1f
Compare
m-jovan
force-pushed
the
migrate-testapp-glimmer
branch
from
7938f1f to
108da8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're freshening up the test-app with migrating components to glimmer and routes to classes. With this we are able to have clearer syntax and unblock future updates of docs libs and ember.
Also this lets us continue with the typescript migration.
The PR is best reviewed commit by commit
This closes #726 since it installs the package and fixes failing actions.