Skip to content

[CORRUPTED] Synthetic Benchmark PR #25664 - Fixed free welcome emails being sent to new paid members#156

Open
ofir-frd wants to merge 6 commits intobase_pr_25664_20260120_2388from
corrupted_pr_25664_20260120_2388
Open

[CORRUPTED] Synthetic Benchmark PR #25664 - Fixed free welcome emails being sent to new paid members#156
ofir-frd wants to merge 6 commits intobase_pr_25664_20260120_2388from
corrupted_pr_25664_20260120_2388

Conversation

@ofir-frd
Copy link

Benchmark PR TryGhost#25664

Type: Corrupted (contains bugs)

Original PR Title: Fixed free welcome emails being sent to new paid members
Original PR Description: closes https://linear.app/ghost/issue/NY-857/free-member-welcome-email-is-sent-to-new-paid-members

Currently if free welcome emails are enabled, and a new member signs up for a paid subscription, they will receive the free welcome email in error. This is because new paid members are initially created in the free status, until the Stripe subscription is fully processed, at which point they transition to paid.

This fixes the bug by opting to skip sending the welcome email if the member has a stripeCustomer attached, which indicates that the member at least intends to become a paid member.
Original PR URL: TryGhost#25664

Compliance Violation

  • Rule: Code Must Use let or const Instead of var
  • Language: JavaScript
  • File: ghost/core/core/server/services/members/members-api/repositories/MemberRepository.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants