Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel apply blocks #2284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

parallel apply blocks #2284

wants to merge 2 commits into from

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Nov 20, 2024 •
edited
Loading

Referenced issues

Description of the Change

  • synchronizer didn't apply blocks in parallel
    • remove applying_in_progress_ flag from applyNextBlock
    • choose multiple blocks to apply instead of first
    • deduplicate generations_, change multimap to set

Possible Drawbacks

@turuslan
parallel apply blocks
cfb62df 
Signed-off-by: turuslan <[email protected]>
Harrm
Harrm reviewed Nov 28, 2024
View reviewed changes
core/network/impl/synchronizer_impl.cpp
}

void SynchronizerImpl::applyNextBlock() {
auto any = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename with more information, its usage is almost hundred lines away from its declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harrm Harrm Harrm left review comments

@kamilsa kamilsa kamilsa approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @Harrm