Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog #21971

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sledgehammer999
Copy link
Member

This is for collecting comments.

Let me know if something doesn't belong here. Or if it should be collapsed with another entry.
Let me know if I missed something.

Remember that the Changelog contains entries usable by the end users. Internal code changes aren't mentioned there.

Each entry has the commit hash beside it to help you navigate the git history.

- WEBUI: Add 'Engine' column to Search table (skomerko) 449ca96e28c56a217ec77d699125d6599f613ff0
- WEBUI: Add confirm dialog for Auto TMM (skomerko) 4ff0687b944a4b293ebf20d70a22b29ff4de8f24
- WEBUI: Add context menu to search tabs (skomerko) 87644441ad88b251913402ece9fd4b6b78f59ff0
- WEBUI: restore arrow keys table navigation (Hanabishi) dfe9daf25d677f77532db86262556653073a00b1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixed something that was broken only in master, arrow navigation works in 5.0.2...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sledgehammer999
I did not track the WebUI changes in detail, but nevertheless I noticed that they had regressions several times, which were hotfixed by subsequent commits. So you should carefully double-check all WebUI related commits to filter out such "hotfixes".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This version of the changelog was compiled semi heuristically by filter by commit title between the two branches and then manually deleting entries that were clearly internal.
I'll double check later to see if they just fixed stuff in master.

- WEBUI: Add context menu to search tabs (skomerko) 87644441ad88b251913402ece9fd4b6b78f59ff0
- WEBUI: restore arrow keys table navigation (Hanabishi) dfe9daf25d677f77532db86262556653073a00b1
- WEBUI: Show file filter when Content tab selected on load (Thomas Piccirello) e8dc6b3f738917e186c75fc956ea632be9081ea4
- WEBUI: Don't sort rows with static trackers in Trackers table (skomerko) 67b6cf5a6f5b8fc83cc1261c8c0ddd984d5e6822
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"DHT, PeX and LSD rows are now (always on top / excluded) from sorting in Trackers table"?

If i hadn't tested that PR i would think it was referring to something like pinned trackers ("we can do that now?").

- WEBUI: Add link to 'List of alternative WebUI' wiki page in Options (Chocobo1) a91bac8aa02b8d562d2c5685f4db2bc4f6ff0a66
- WEBUI: Improve properties panel, torrent deletion dialog, filter list, subcategories, torrent deletion, statistics window (skomerko) fda797cb76526114941f595114ca3404246886cb 39dd415d43eaa9a2552273c667152a5c7e3e5d13 (5b7c9d5725d1e47dde39081e4fdadbc23cd40ca8 + 81509dfb6554f3cf5679a6dd560b37c54bc77a2c) 1b53fdf9ee40ca5472246c3bc073d47b7306588d 0ea35c54a347bbfddf97f0b61982416f27ee52b4 5e3161a3f96335ce906c0248ac888a3a55509c2a
- WEBUI: Allow to display only hostname in the Tracker column (skomerko) 9d0fa213bed6172d269afd7364769eca66f16631
- WEBUI: Show country/region name next to its flag when 'Resolve peer countries' is enabled (skomerko) f681e954c7d84d4add53cc6f8908337916efa94b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "when 'Resolve peer countries' is enabled" superfluous?

Changelog Outdated Show resolved Hide resolved
Changelog Outdated Show resolved Hide resolved
- WEBAPI: Add `forced` parameter to `torrents/add` (Chris B) f022ce8f84c85438fd8f5505a037d7d2f8da6d5c
- RSS: Don't add duplicate episodes to previously matched (wavygecko) d11622e3c0e1fecf8550e4f5a70f925424aaec5b
- SEARCH: Bump Python version minimum requirement (Chocobo1) 8b7fdf0f229d69c63fb0e96780f276fe6c8a620e
- SEARCH: Simplify tab handling in Search widget (Chocobo1) 6f642776b67e1560332926730913681f8690bf97
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it just a code cleanup?

Changelog Outdated Show resolved Hide resolved
@Chocobo1
Copy link
Member

Chocobo1 commented Dec 8, 2024

@sledgehammer999
IMO the following are worth mentioning in changelog:

  • WebUI improvements #21074
    It has a few commits that would help assistive technologies (e.g. screen readers).
  • Improve PRNG functions #21333
    More or less related with security, it could be mentioned.
  • The WebUI has undergone a lot of internal refactors. Mostly migrating away from mootools and to native browser API. It could worth a mention.

@xavier2k6

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants