Support fetching tracker list from URL #21828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trackers specified at the URL will be added to newly added public torrents.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+3977
to
+3985
| case Net::DownloadStatus::Success: | ||
| setAdditionalTrackersFromURL(QString::fromUtf8(result.data.data())); | ||
| LogMsg(tr("Public tracker list updated"), Log::INFO); | ||
| break; | ||
| default: | ||
| LogMsg(tr("Failed to update public tracker list. Reason: \"%1\"").arg(result.errorString), Log::WARNING); | ||
| break; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
|
I see only 1 problem: The box for |
|
Supersedes? #20115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is adapted from qBittorrent-Enhanced-Edition to allow for automatically adding trackers retrieved from a URL. @ngosang's trackerlist repo is a good example, however I've opted not to include a default URL.
Partially addresses #14535.