Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display feeds as tree in RSS downloader #18440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pioooooo
Copy link

@Pioooooo Pioooooo commented Jan 22, 2023

This PR changes the RSS downloader dialog to use a tree for its feed list.

It is annoying if there are a lot of RSS feeds to be selected. By using a tree display it reduces this one-by-one selection effort and is more organized and consistent with the RSS reader feed list.

Closes #16802, #1805.
图片
Currently not adding icons for the tree as the previous feed list didn't, but maybe it is better to display one to indicate one is a folder or feed?
Also for the root folder is there need for a name?

@glassez
Copy link
Member

glassez commented Jan 23, 2023

Also for the root folder is there need for a name?

It would be nice to see something different from an empty space. Maybe the *nix-like name of the root folder / would do?

maybe it is better to display one to indicate one is a folder or feed?

👍

@glassez glassez added RSS RSS-related issues/changes GUI GUI-related issues/changes labels Jan 23, 2023
@Pioooooo
Copy link
Author

图片
Added icons and root path. I think it is okay not to show RSS isLoading or hasError icon, as those are mostly temporary stuff and the site icon helps find the feed?

@glassez
Copy link
Member

glassez commented Jan 24, 2023

I think it is okay not to show RSS isLoading or hasError icon

Exactly. It would be too superfluous in this place.

@glassez glassez self-assigned this Jan 24, 2023
@Pioooooo
Copy link
Author

Should I do a rebase or what to remove the trailing spaces?

@glassez
Copy link
Member

glassez commented Jan 25, 2023

Should I do a rebase or what to remove the trailing spaces?

It's better to rebase.

@Pioooooo Pioooooo force-pushed the rss-downloader-feed-tree branch from be40e96 to a7d4c16 Compare January 25, 2023 09:29
@glassez
Copy link
Member

glassez commented Feb 17, 2023

@Pioooooo
What is the status of this PR? Do you intend to finish it? It's still marked as a Draft.

@Pioooooo Pioooooo marked this pull request as ready for review February 17, 2023 12:14
@Pioooooo
Copy link
Author

@Pioooooo What is the status of this PR? Do you intend to finish it? It's still marked as a Draft.

Sorry, I am not familiar with GitHub pull requests and it is now ready for review I guess.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 20, 2023

@Pioooooo can you rebase ?

This allows for applying rules to all feeds. Closes qbittorrent#1805.
Also add "/" as root folder path name, set root folder default expanded.
@Pioooooo Pioooooo force-pushed the rss-downloader-feed-tree branch from a7d4c16 to 46eb984 Compare September 23, 2023 11:33
@Pioooooo
Copy link
Author

@luzpaz I think it's done now.

@luzpaz

This comment was marked as resolved.

@luzpaz luzpaz requested a review from a team September 23, 2023 14:31
@xavier2k6

This comment was marked as resolved.

@luzpaz
Copy link
Contributor

luzpaz commented Nov 3, 2023

I haven't tested but this looks cleaner. Anyone who uses RSS often care to test and weigh-in ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes RSS RSS-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Download rules addition in RSS Downloader
4 participants