Duplicate license check: By MrCrowley

[gononono64]

Description

Duplicate license check just...doesnt work
Because of that this happens: https://www.youtube.com/watch?v=U1Pxpxuj7-o
If you bother to look into this you will realize you should merge this pretty much asap

PS I got lazy and rewrote what i did through the github editor. Its just a few minor modifications that i did. I also did these modifications on another server that was having the same issue. Person who brought it to my attention.

Please make sure i didnt miss anything. AKA make sure to test it

Checklist

• I have personally loaded this code into an updated qbcore project and checked all of its functionality.
• My code fits the style guidelines.
• My PR fits the contribution guidelines.

[gononono64]

There, next time dont approve things the linter doesnt accept...her der

[iboss21]

we personally tested it on our server and fixed it now. thanks to MrCrowley

[Sh3ldar]

tested and working the commands.lua and functions.lua part is not needed for merge

[gononono64]

tested and working the commands.lua and functions.lua part is not needed for merge

commands is needed for linter, functions there was a redundant check

[ChristianBDev]

LGTM | Tested and it works

[Qwerty1Verified]

What part of the original code stops it from working? Is it the retrieving of the licenses before waiting that's stopping it?

[ChristianBDev]

What part of the original code stops it from working? Is it the retrieving of the licenses before waiting that's stopping it?

This is where it is stopping it,

-- if GetConvarInt('sv_fxdkMode', false) then
    --     license = 'license:AAAAAAAAAAAAAAAA' -- Dummy License
    -- end

    if not license then
        deferrals.done(Lang:t('error.no_valid_license'))
    elseif QBConfig.Server.CheckDuplicateLicense and QBCore.Functions.IsLicenseInUse(license) then

[Qwerty1Verified]

Checking that convar should be doable, this is the normal documented usage though local fxdkMode = GetConvarInt('sv_fxdkMode', 0) == 1

[gononono64]

Checking that convar should be doable, this is the normal documented usage though local fxdkMode = GetConvarInt('sv_fxdkMode', 0) == 1

For what purpose?

[Qwerty1Verified]

Its purpose is to allow the usage of the Cfx.re Development Kit (FxDK). The edit on line 50 of the events.lua file also seems unnecessary.

[gononono64]

Its purpose is to allow the usage of the Cfx.re Development Kit (FxDK). The edit on line 50 of the events.lua file also seems unnecessary.
QBConfig.Server.CheckDuplicateLicense is definitely needed as its checking the config as it should. The previous was a typo

[Qwerty1Verified]

It was previously checking the config through QBCore.Config

[gononono64]

It was previously checking the config through QBCore.Config

[Qwerty1Verified]

qb-core/server/main.lua

Line 2 in a866b1a

QBCore.Config = QBConfig

QBCore.Config is a variable alias defined by QBConfig

[gononono64]

qb-core/server/main.lua

Line 2 in a866b1a

QBCore.Config = QBConfig

QBCore.Config is a variable alias defined by QBConfig

Well i can tell you from experience, being a developer and having to figure out what links where without any search options, is simply bad design. Makes it much harder to decode. At this point take it or leave it

[Qwerty1Verified]

It's usually just a matter of best practice, hence why getters and setters exist to prevent access to the original data structure. People write code differently, but this is usually the practice that is followed. When most of the other code uses QBCore.Config, it can be assumed that it works if it hasn't been modified, and then of course a quick search for QBCore.Config would reveal that it is a real variable and has a role

[gononono64]

It's usually just a matter of best practice, hence why getters and setters exist to prevent access to the original data structure. People write code differently, but this is usually the practice that is followed. When most of the other code uses QBCore.Config, it can be assumed that it works if it hasn't been modified, and then of course a quick search for QBCore.Config would reveal that it is a real variable and has a role

[Qwerty1Verified]

Yeah that's why I said different people write code differently and that most of the other code uses QBCore.Config. Simply trying to follow best practice, and that's just a few occasions where it's using QBConfig. I'm glad you found the cause of the bug though

[Qwerty1Verified]

Has it been tested since the convar check was added back in? It'll be nice to see a bug like this fixed

[iboss21]

I m glad its fixed and servers owners as myself can be relaxed. Thank you guys and thanks to QBCore Community for this fast response and fixing it.

Truly appreciated.

[gononono64]

Has it been tested since the convar check was added back in? It'll be nice to see a bug like this fixed

yes. have not tested the convar itself tho

[GhzGarage]

d7323ba