-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the majority of the backend codebase #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not letting people submit in ASM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of a scuffed way to sort, but if you can think of better LMK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, but should be changed to something better in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using Object.entries
instead of Object.keys
. It seems that there are too many users[0].problems
repeated.
- 8|32: floating point exception | ||
- 8|64: aborted | ||
- 8|128: disallowed system call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some touching up required but otherwise I think its almost ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assembly support is mandatory and must be added before this PR is approved.
Fuck you |
lmao just saw this meme |
Same here lmaoooo |
Based |
BASEDD |
LMAO 😂 |
Based |
I just saw the memes |
To all the people who came here or will be coming here after watching the meme, Now, think twice if you want to reply "Based". Think how kevlu8 can reply better than you. Cuz... kevlu8 is the goat. |
At least I'm Elon Musk |
Bro summoned the internet |
based hololive enjoyer |
I'm here too 😎 |
Thank you for this. Very based |
Based |
mfw i summon 1000 unnamed people to my pr with a single message |
this is epic lol |
most peaceful github PR conversation |
based |
Dammm |
hello |
Hi |
The most based skill issue ever |
Stress testing GitHub's comment section |
This guy reunited the entire developer base with just a single phrase. |
"Violence is not the answer. It is the question and the answer is yes." |
BASED AF |
i shall be part of history, may your pulls be merged and your push be forced |
based |
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ |
lmfao |
wow hahahaha what even is this |
Jumle was here |
late to the party but good shit broski |
I'm here for the memes |
Based AF! and I also think you should check out my band at https://soundcloud.com/corporation-swine |
Based 🤣 |
Great. Now I'm going to have to drive all the way down to Melbourne just to boo a "punk" band while holding up a poster sized version of this comment. B-based? Thanks a lot GitHub. |
Definitely not a punk band. Not even close. |
Great, now I have to drive all the way down to Melbourne to support a band because I feel bad. Thanks a lot punkoffice. I have some mates down there, so if the stars align and one night your band mates ask "wtf is that guy holding a 'best punk band ever' sign"? You'll know why. |
Well if you ever come to Melbourne I'll shout you a beer for making me laugh with this exchange |
Judge changes:
constexpr
shenanigans won't occur)Backend changes:
/api/login
Frontend changes: