Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the majority of the backend codebase #1

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Refactor the majority of the backend codebase #1

merged 5 commits into from
Aug 12, 2024

Conversation

kevlu8
Copy link
Member

@kevlu8 kevlu8 commented Aug 12, 2024

Judge changes:

  • Update the judge to communicate with the web backend in a more conventional and standardized manner
    • Judge now outputs [status] [memory] [time]
  • Fix memory grabbing for all submissions (Java memory is now fixed)
  • Set resource limits for the compiler (so constexpr shenanigans won't occur)
  • Improve logging (though race conditions are still possible)

Backend changes:

  • Fix behind-by-one-case bug during submission grading
  • Add rate limiting for /api/login

Frontend changes:

  • Add live leaderboard page to display results on-the-fly
  • Update leaderboard to be sorted by problem difficulty
  • Fix logging out
  • Add countdown to contest end on contest page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not letting people submit in ASM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a scuffed way to sort, but if you can think of better LMK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but should be changed to something better in the future.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Object.entries instead of Object.keys. It seems that there are too many users[0].problems repeated.

- 8|32: floating point exception
- 8|64: aborted
- 8|128: disallowed system call
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be changed

Copy link
Member Author

@kevlu8 kevlu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some touching up required but otherwise I think its almost ready

@kevlu8 kevlu8 requested a review from wdotmathree August 12, 2024 03:40
@wdotmathree wdotmathree self-requested a review August 12, 2024 03:40
Copy link
Member

@wdotmathree wdotmathree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to merge.

Copy link
Member

@wdotmathree wdotmathree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assembly support is mandatory and must be added before this PR is approved.

@kevlu8
Copy link
Member Author

kevlu8 commented Aug 12, 2024

Fuck you

@kevlu8 kevlu8 merged commit 73aa662 into master Aug 12, 2024
@wdotmathree wdotmathree deleted the refactor branch August 12, 2024 03:51
@wdotmathree wdotmathree restored the refactor branch August 12, 2024 03:51
@kevlu8 kevlu8 deleted the refactor branch August 12, 2024 16:34
@ansh3108
Copy link

lmao just saw this meme

https://www.instagram.com/reels/C-2v8lLSCZo/

@subhramit
Copy link

lmao just saw this meme

https://www.instagram.com/reels/C-2v8lLSCZo/

Same here lmaoooo

@Binozo
Copy link

Binozo commented Aug 20, 2024

Fuck you

Based

@Shreyaan
Copy link

Fuck you

BASEDD

@pramodhrachuri
Copy link

LMAO 😂
Coming here after watching the meme

@RechieKho
Copy link

Based

@MaestroMiyagi
Copy link

I just saw the memes
Based

@Keyrxng
Copy link

Keyrxng commented Aug 21, 2024

Come get paid

@pramodhrachuri
Copy link

pramodhrachuri commented Aug 21, 2024

To all the people who came here or will be coming here after watching the meme,
kevlu8 can code, play chess, make yt videos (3.9K subs), and also troll others in Valorant. kevlu8 is the goat.
While a normal dude can try to master one of them, kevlu8 mastered all of them. kevlu8 is the goat.
I too can code, play chess, make videos and play Valorant. But I suck in all of them. kevlu8 is the goat.

Now, think twice if you want to reply "Based". Think how kevlu8 can reply better than you. Cuz... kevlu8 is the goat.

image(2)

@RechieKho
Copy link

At least I'm Elon Musk

@venom7aries
Copy link

Fuck you

Bro summoned the internet

@tusharsadhwani
Copy link

based hololive enjoyer

@rojasjo
Copy link

rojasjo commented Aug 31, 2024

I'm here too 😎

@Fieoner
Copy link

Fieoner commented Aug 31, 2024

Thank you for this. Very based

@KellyNyanbinary
Copy link

Based

@korbosoft
Copy link

mfw i summon 1000 unnamed people to my pr with a single message

@gamecuber6
Copy link

this is epic lol

@zshaian
Copy link

zshaian commented Aug 31, 2024

most peaceful github PR conversation

@Z1xus
Copy link

Z1xus commented Sep 1, 2024

based

@BRAVO68WEB
Copy link

Dammm

@lorencmateusz
Copy link

hello

@nawaphonOHM
Copy link

Hi

@0strikephoenix
Copy link

Fuck you

The most based skill issue ever
You are now the talk of LowRes

@GregHanson
Copy link

Stress testing GitHub's comment section

@felipegarcia99
Copy link

This guy reunited the entire developer base with just a single phrase.

@xantaren
Copy link

xantaren commented Sep 3, 2024

"Violence is not the answer. It is the question and the answer is yes."

@warp-records
Copy link

Fuck you

BASED AF

@geomydas
Copy link

geomydas commented Sep 9, 2024

i shall be part of history, may your pulls be merged and your push be forced

@jed1337
Copy link

jed1337 commented Sep 9, 2024

based

@sunwoo0706
Copy link

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ

@mcschwa
Copy link

mcschwa commented Sep 10, 2024

lmfao

@hrithikm2
Copy link

wow hahahaha what even is this

@JumleDumle
Copy link

Jumle was here

@Lyceris-chan
Copy link

late to the party but good shit broski

@Lizardbutt
Copy link

I'm here for the memes

@punkoffice
Copy link

Based AF! and I also think you should check out my band at https://soundcloud.com/corporation-swine

@Readiz
Copy link

Readiz commented Nov 5, 2024

Based 🤣

@nate235
Copy link

nate235 commented Dec 1, 2024

Based AF! and I also think you should check out my band at https://soundcloud.com/corporation-swine

Great. Now I'm going to have to drive all the way down to Melbourne just to boo a "punk" band while holding up a poster sized version of this comment. B-based? Thanks a lot GitHub.

@punkoffice
Copy link

Great. Now I'm going to have to drive all the way down to Melbourne just to boo a "punk" band while holding up a poster sized version of this comment. B-based? Thanks a lot GitHub.

Definitely not a punk band. Not even close.

@nate235
Copy link

nate235 commented Dec 2, 2024

Definitely not a punk band. Not even close.

Great, now I have to drive all the way down to Melbourne to support a band because I feel bad. Thanks a lot punkoffice. I have some mates down there, so if the stars align and one night your band mates ask "wtf is that guy holding a 'best punk band ever' sign"? You'll know why.

@punkoffice
Copy link

Definitely not a punk band. Not even close.

Great, now I have to drive all the way down to Melbourne to support a band because I feel bad. Thanks a lot punkoffice. I have some mates down there, so if the stars align and one night your band mates ask "wtf is that guy holding a 'best punk band ever' sign"? You'll know why.

Well if you ever come to Melbourne I'll shout you a beer for making me laugh with this exchange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment