Skip to content

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Aug 29, 2025

Stack from ghstack (oldest at bottom):

Motivation

Prepare for shaders that will use accelerated int8 dot product GLSL extensions, i.e. dotPacked4x8AccSatEXT

Changes

  • Query for support for the shader integer dot product extension when creating the VkPhysicalDevice
  • Request the shader integer dot product extension when creating VkDevice
  • Provide APIs to check if the extension is available in the current runtime.

Differential Revision: D81323427

…upgrade glslc

## Motivation

Prepare for shaders that will use accelerated int8 dot product GLSL extensions, i.e. `dotPacked4x8AccSatEXT`

## Changes

* Query for support for the shader integer dot product extension when creating the VkPhysicalDevice
* Request the shader integer dot product extension when creating VkDevice
* Provide APIs to check if the extension is available in the current runtime.

Differential Revision: [D81323427](https://our.internmc.facebook.com/intern/diff/D81323427/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13814

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 16 New Failures, 3 Unrelated Failures

As of commit 1c282de with merge base e2098f8 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81323427

… support + upgrade glslc"

## Motivation

Prepare for shaders that will use accelerated int8 dot product GLSL extensions, i.e. `dotPacked4x8AccSatEXT`

## Changes

* Query for support for the shader integer dot product extension when creating the VkPhysicalDevice
* Request the shader integer dot product extension when creating VkDevice
* Provide APIs to check if the extension is available in the current runtime.

Differential Revision: [D81323427](https://our.internmc.facebook.com/intern/diff/D81323427/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D81323427

@facebook-github-bot facebook-github-bot merged commit bb6e8b3 into gh/SS-JIA/314/base Aug 30, 2025
220 of 241 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/314/head branch August 30, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants