Update tkinter.Text.count for 3.13
#12368
Conversation
stdlib/tkinter/__init__.pyi
Outdated
| return_ints: Literal[True], | ||
| ) -> int: ... | ||
| else: | ||
| def count(self, index1: _TextIndex, index2: _TextIndex, *options: _CountOptions) -> tuple[int, ...]: ... |
There was a problem hiding this comment.
The old docstring claims this could return a list of integers, but that seems to be false.
max-muoto
force-pushed
the
update-tkinter-text-count
branch
from
7f8bb8b
to
3059d51
Compare
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| if sys.version_info >= (3, 13): | ||
| @overload | ||
| def count( | ||
| self, index1: _TextIndex, index2: _TextIndex, *options: Unpack[tuple[_CountOptions]], return_ints: Literal[True] |
There was a problem hiding this comment.
If I'm reading the docstring right, this isn't quite correct: if one of the options is update, then that doesn't produce an extra value.
Typing this fully precisely seems difficult and possibly not worth the trouble.
cc @Akuli for opinions on tkinter.
There was a problem hiding this comment.
This method is just awful to work with without the return_ints parameter. Before that parameter existed, I wrote my own just to avoid figuring out how it works.
That said, typing this method is probably worth the effort:
- it is tempting to use
.count()and easy to forget some corner case - most people can't assume Python 3.13 yet
I think I'll just write the overloads and push directly into this PR's branch. decided to make new PR
| def count( | ||
| self, index1: _TextIndex, index2: _TextIndex, *options: Unpack[tuple[_CountOptions]], return_ints: Literal[True] | ||
| ) -> int: ... | ||
| # If there are 2+ options, then a tuple of ints is always returned. |
There was a problem hiding this comment.
This is not true if you specify "update" and some other option. I'll make a new PR that adds overloads for this...
|
This now has a merge conflict, but it should be much simpler now that #12395 is merged. |
Add new
return_intsargument, and add appropiate overloads.