Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#2492): use newest compose command #2558

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(#2492): use newest compose command #2558

merged 1 commit into from
Sep 16, 2024

Conversation

JacobCoffee
Copy link
Member

Description

  • Update to new compose subcommand

Closes

@JacobCoffee
Copy link
Member Author

JacobCoffee commented Sep 13, 2024 •
edited
Loading

Unsure of the impact on

pythondotorg/docker-compose.yml

Line 27 in 624dc3a

image: pythondotorg:docker-compose
but make targets themselves ran

✗ make clean && make serve
docker compose down -v

@ewdurbin
Copy link
Member

Unsure of the impact on

pythondotorg/docker-compose.yml

Line 27 in 624dc3a

image: pythondotorg:docker-compose

That's just the resulting tagged name of the image so it can be re-used in the worker container. So all is well.

@ewdurbin ewdurbin merged commit 7eac335 into main Sep 16, 2024
6 checks passed
@ewdurbin ewdurbin deleted the docker-compose-command-update-#2492 branch September 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin Awaiting requested review from ewdurbin ewdurbin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docker] Switch to the built-in compose plugin
2 participants
@JacobCoffee @ewdurbin