Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give admin user a preview of sponsorship package revenue splits #2529

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

indepndnt
Copy link
Contributor

This adds information to the admin screen for Sponsorship Packages about the revenue split for unmodified sponsorships.

Screenshot from 2024-09-11 08-17-52

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions after running this locally.

I'm +1 to this if we add a bit stronger of a test, perhaps having multiple packages with multiple different values.

@indepndnt
Copy link
Contributor Author

Thanks Ee! I had initially thought about using the Python colors but then I went a different way. I beefed up the test and applied your suggestions.

@ewdurbin
Copy link
Member

Thanks @indepndnt, this looks great!

@ewdurbin ewdurbin merged commit ce1c391 into python:main Sep 12, 2024
2 checks passed
ewdurbin added a commit that referenced this pull request Sep 12, 2024
A small, hard to notice change was present in my suggestion that wasn't picked up.
ewdurbin added a commit that referenced this pull request Sep 12, 2024
A small, hard to notice change was present in my suggestion that wasn't picked up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants