Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration from 2.2 -> 3.2 -> 4.2 #2520

Merged
merged 24 commits into from
Sep 12, 2024
Merged

feat: migration from 2.2 -> 3.2 -> 4.2 #2520

merged 24 commits into from
Sep 12, 2024

Conversation

JacobCoffee
Copy link
Member

What

  • Migration of Django from 2.x to 4.2

Closes

@JacobCoffee
Copy link
Member Author

#2413 was based on a fork, but I have since joined the team so no need for forks.
I will be going through the #2413 unfinished items though.

@JacobCoffee
Copy link
Member Author

Quite a bit less migrations after changing from BigAuto to just Auto! :)

base-requirements.txt Outdated Show resolved Hide resolved
JacobCoffee and others added 4 commits September 9, 2024 16:27
…TION

ACCOUNT_PREVENT_ENUMERATION was introduced in django-allauth 0.52.0, and interferes with our expectations.

This should probably be turned on! But for now disable it by default to keep the changeset minimal.

Allauth _used_ to iterate over users to check for email uniquenss but stopped at some point, so we have to create an EmailAdress object for the user in the relevant test-case for duplicate emails
@JacobCoffee
Copy link
Member Author

Whats the path to standing this up as staging.python.org @ewdurbin ?

@ewdurbin
Copy link
Member

staging was retired years ago for numerous reasons, but the main one being that representative data for most features wasn't present there... so it was ultimately only valuable for previewing frontend changes.

we would need to create a new deployment from scratch at this point, and populate it with some representative data.

@JacobCoffee
Copy link
Member Author

@ewdurbin Is it a big ask to have prod data load periodically into staging to keep it fresh? OR atleast lightweight fixture data that has things we test frequently?

@ewdurbin
Copy link
Member

I'm a pretty massive -1 on prod -> staging copy concept. There are a lot of side-effects that could occur to send email or update information that would be hard to keep track of. Aside from that there's just the duplication of private information.

If a reasonable set of fixtures existed (sufficient for local development/testing) that would be a splendid base for a staging environment though, and I'd be +1 to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Django 3.2 LTS version
2 participants