Use dedicated tags for most common instances #19762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses dedicated secondary type tags to 5 most common instances. I also move the instance cache from
checker.pytotypes.pyso it is easier to share. The latter however requires couple tweaks to not break builtins fixtures in tests (see changes inbuild.pyandcheckexpr.py).This makes cache another ~20% smaller (so that with this PR FF is 4.5x smaller than JSON), and also this makes
mypy -c 'import torch'almost 10% faster with warm cache (when one uses--fixed-format-cacheobviously). I don't see any visible effect on cold cache runs.