Fixed spelling issues. #17774
Fixed spelling issues. #17774
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Staging unstaged changes before pull Update testtypes.py
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mypy/fastparse.py
Outdated
| @@ -2249,7 +2249,7 @@ def visit_member_expr(self, e: MemberExpr) -> None: | |||
|
|
|||
|
|
|||
| class FindYield(TraverserVisitor): | |||
| """Check if an AST contains yields or yield froms.""" | |||
| """Check if an AST contains yields or yield forms.""" | |||
There was a problem hiding this comment.
I think this refers to "yield from" (https://docs.python.org/3/whatsnew/3.3.html#pep-380), so it's written as intended?
There was a problem hiding this comment.
It seems like "from" is the correct terminology as per PEP 380 (https://docs.python.org/3/whatsnew/3.3.html#pep-380), so the original phrasing is accurate. The update might not be necessary.
mypyc/ir/module_ir.py
Outdated
| @@ -28,7 +28,7 @@ def __init__( | |||
| self.functions = functions | |||
| self.classes = classes | |||
| self.final_names = final_names | |||
| # Names of C statics used for Python 3.12 type variable objects. | |||
| # Names of C statistics used for Python 3.12 type variable objects. | |||
There was a problem hiding this comment.
I think this refers to "C statics" as in "C static variables". That terminology is used elsewhere in mypyc (example), so I think this is written as intended
There was a problem hiding this comment.
Thanks for pointing that out! I'll leave it as is since "statics" seems to be the correct terminology.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This pull request addresses several spelling and wording corrections in various files across the mypy repository. These changes are aimed at improving the readability of comments and documentation, ensuring clarity for future developers and contributors.
Changes Made:
№ 1: Corrected spelling errors such as “overriden” to “overridden” and “yields or yield froms” to “yields or yield forms”.
№ 2: Updated in-line comments to enhance their clarity while keeping the original meaning intact.
№ 3: Modified wording in CHANGELOG.md and other files to maintain consistency and precision.
↝ These corrections are purely to improve code readability and documentation quality. No functional changes were made to the codebase.