Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.14 now is the main branch #1383

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Python 3.14 now is the main branch #1383

merged 1 commit into from
Aug 31, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Aug 31, 2024

Also add turtledemo expert (Today new codeowner) python/cpython@1ce9e58


📚 Documentation preview 📚: https://cpython-devguide--1383.org.readthedocs.build/

Comment on lines 227 to +228
turtle gregorlingl^, willingc
turtledemo terryjreedy*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there's much point having two distinct entries?

We should also check that @terryjreedy is content to be listed as a turtle expert, as CODEOWNERS and the experts list are not bijective.

Copy link
Contributor Author

@Wulian233 Wulian233 Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TurtleDemo is a GUI program lib, can open with IDLE. turtle is a module

We should also check that @terryjreedy is content to be listed as a turtle expert, as CODEOWNERS and the experts list are not bijective.

He said python/cpython#123370 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turtle is to turtledemo somewhat as tkinter is to idlelib. Yes, I approve of this addition.

@hugovk hugovk merged commit 1a5919c into python:main Aug 31, 2024
5 checks passed
@Wulian233 Wulian233 deleted the patch-1 branch August 31, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants