Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve forking instructions (#1375) #1376

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

kevinbowen777
Copy link
Contributor

@kevinbowen777 kevinbowen777 commented Aug 18, 2024

  • Add item to uncheck "Copy main branch only" button
  • Add git fetch upstream command to creating branches section

📚 Documentation preview 📚: https://cpython-devguide--1376.org.readthedocs.build/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions.

getting-started/git-boot-camp.rst Outdated Show resolved Hide resolved
getting-started/git-boot-camp.rst Outdated Show resolved Hide resolved
getting-started/git-boot-camp.rst Outdated Show resolved Hide resolved
getting-started/git-boot-camp.rst Outdated Show resolved Hide resolved
getting-started/git-boot-camp.rst Outdated Show resolved Hide resolved
@kevinbowen777
Copy link
Contributor Author

@hugovk @ezio-melotti

Is there anything more needed from me to get this PR merged? I'm not very familiar with how PR reviews work on GitHub. Thanks.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @kevinbowen777. I will let @hugovk and @ezio-melotti review that their comments have been incorporated. It looks like they have to me. Thanks!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🚀

@hugovk hugovk merged commit df76764 into python:main Aug 23, 2024
4 checks passed
@kevinbowen777 kevinbowen777 deleted the update_git_bootstrap_devguide_1375 branch August 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants