Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add htmllive to make.bat #1373

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Add htmllive to make.bat #1373

merged 4 commits into from
Sep 2, 2024

Conversation

lorenzo-delsignore
Copy link
Contributor

@lorenzo-delsignore lorenzo-delsignore commented Aug 14, 2024 •
edited by github-actions bot
Loading

This pull request fixes #1366 issue by adding the htmllive command to the make.bat script.

📚 Documentation preview 📚: https://cpython-devguide--1373.org.readthedocs.build/

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Aug 14, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@ezio-melotti ezio-melotti self-assigned this Aug 14, 2024
ezio-melotti
ezio-melotti reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can someone on Windows verify that it works as expected?

hugovk
hugovk reviewed Aug 14, 2024
View reviewed changes
make.bat Outdated Show resolved Hide resolved
make.bat Outdated Show resolved Hide resolved
@lorenzo-delsignore @hugovk
Fix typo
c7129ec 
Co-authored-by: Hugo van Kemenade <[email protected]>
@lorenzo-delsignore
Copy link
Contributor Author

lorenzo-delsignore commented Aug 14, 2024 •
edited
Loading

I think that renaming the variables of SPHINXBUILD and SPHINXAUTOBUILD with something more readable will need a change of the Makefile of Linux too to be consistent. The problem is that the Makefile use only SPHINXBUILD variable, instead with Windows I only found this solution. In my opinion is better to mantain these two variables in the make.bat file.

@hugovk
Copy link
Member

hugovk commented Aug 14, 2024

Sure, we can keep the ALLONEWORD ones in this PR. Thanks!

@AA-Turner
Copy link
Member

Resolved merge conflicts, given I created them.

A

@ezio-melotti ezio-melotti merged commit b603868 into python:main Sep 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

@hugovk hugovk hugovk left review comments

Assignees

@ezio-melotti ezio-melotti

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add htmllive target to make.bat
4 participants
@lorenzo-delsignore @hugovk @AA-Turner @ezio-melotti