Don't suggest to start build with infinite number of threads #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Just a small enhancement proposal, as I don't think calling
make
with unbounded number of threads is desirable.Using
make -j
will start "infinite" number of jobs according tomake
docs, which slows down the build and consumes too many resources.Suggesting
make -j4
seems to be a sane default, advanced users will know how to adjust it.📚 Documentation preview 📚: https://cpython-devguide--1087.org.readthedocs.build/