-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
gh-116946: add Py_TPFLAGS_IMMUTABLETYPE
to select.[e]poll
#138340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116946: add Py_TPFLAGS_IMMUTABLETYPE
to select.[e]poll
#138340
Conversation
select.[e]poll
select.[e]poll
50a32c4
to
55c88e4
Compare
55c88e4
to
775f809
Compare
select.[e]poll
Py_TPFLAGS_IMMUTABLETYPE
to select.[e]poll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I don't know if "cannot create cycles as it only contains exact ints" comment is correct or not.
Misc/NEWS.d/next/Library/2025-09-02-10-27-21.gh-issue-116946.VxXNGD.rst
Outdated
Show resolved
Hide resolved
That's why I actually asked. The ints are constructed internally (AFAIU) so I that's why I didn't visit the dictionary. But I can visit it just to be sure. |
…xXNGD.rst Co-authored-by: Victor Stinner <[email protected]>
I'm not sure about kqueue as I can't check this myself. However note the following leak on main:
Instead of implementing the full GC protocol, we can make the types immutable.
Rationale for not backporting this: #138341 (comment).