-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125498: Update JIT builds to use LLVM 19 and use preserve_none
#125499
Conversation
So it looks like the Python version installed with |
Update as of 10/22: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few opportunities to tidy things up:
Misc/NEWS.d/next/Core_and_Builtins/2024-10-22-04-18-53.gh-issue-125498.cFjPIn.rst
Outdated
Show resolved
Hide resolved
…e-125498.cFjPIn.rst Co-authored-by: Brandt Bucher <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
Oooo, thanks for the review @brandtbucher. Great catches for cleaning things up a bit. Much simpler. |
preserve_none
in JIT buildspreserve_none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! @mdboom, I'm landing this, so we should probably also update the benchmark runners that need it. Let me know if you want help.
Yep -- I'll do that now. |
…e_none (pythonGH-125499)" This reverts commit c29bbe2.
preserve_none
in JIT builds #125498