Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124130: Notes on empty string corner case of category \B #124133

Merged
merged 1 commit into from
Sep 23, 2024
Merged

gh-124130: Notes on empty string corner case of category \B #124133

merged 1 commit into from
Sep 23, 2024

Conversation

y5c4l3
Copy link
Contributor

@y5c4l3 y5c4l3 commented Sep 16, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Sep 16, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Sep 16, 2024
Open
@y5c4l3 y5c4l3 changed the title gh-124130: Match empty string for regex category \B gh-124130: Match empty strings for regex category \B Sep 16, 2024
@y5c4l3 y5c4l3 force-pushed the re-non-boundary branch 2 times, most recently from 01515bd to 5dfaf17 Compare September 16, 2024 16:15
ZeroIntensity
ZeroIntensity requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a breaking change, as mentioned in the original issue :(

Could you just add a documentation note with this PR?

@y5c4l3 y5c4l3 changed the title gh-124130: Match empty strings for regex category \B gh-124130: Notes on empty string corner case of category \B Sep 21, 2024
@y5c4l3
Copy link
Contributor Author

y5c4l3 commented Sep 21, 2024

Could you just add a documentation note with this PR?

Notes added. Could you label this PR with a skip news tag?

@ZeroIntensity ZeroIntensity added docs Documentation in the Doc dir skip news labels Sep 21, 2024
ZeroIntensity
ZeroIntensity approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! This is pretty much all we can do about this problem.

@ZeroIntensity ZeroIntensity added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 21, 2024
vstinner
vstinner approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

picnixz
picnixz reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check that Perl is indeed different or use another example (or drop it if you want).

Doc/library/re.rst Outdated Show resolved Hide resolved
@y5c4l3 @picnixz
Notes on empty string corner case of category \B
947bc09 
Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@vstinner vstinner merged commit d3e79d7 into python:main Sep 23, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @y5c4l3 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
@y5c4l3 @picnixz @miss-islington
pythongh-124130: Notes on empty string corner case of category \B (p…
6c81c7f 
…ythonGH-124133)

(cherry picked from commit d3e79d7)

Co-authored-by: Y5 <[email protected]>
Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124328 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
@y5c4l3 @picnixz @miss-islington
pythongh-124130: Notes on empty string corner case of category \B (p…
2d79509 
…ythonGH-124133)

(cherry picked from commit d3e79d7)

Co-authored-by: Y5 <[email protected]>
Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124329 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 23, 2024
@vstinner
Copy link
Member

Merged, thanks.

vstinner pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @y5c4l3 @picnixz
[3.12] gh-124130: Notes on empty string corner case of category \B (G…
d5aafe7 
…H-124133) (#124329)

gh-124130: Notes on empty string corner case of category `\B` (GH-124133)
(cherry picked from commit d3e79d7)

Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Y5 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @y5c4l3 @picnixz
[3.13] gh-124130: Notes on empty string corner case of category \B (G…
5760330 
…H-124133) (#124328)

gh-124130: Notes on empty string corner case of category `\B` (GH-124133)
(cherry picked from commit d3e79d7)

Signed-off-by: y5c4l3 <[email protected]>
Co-authored-by: Y5 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@picnixz picnixz picnixz left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y5c4l3 @vstinner @picnixz @ZeroIntensity @rruuaanng