You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm pretty sure this should fix both reasons for failing CI on main.
I'm also seeing this in the logs:
=========== 857 passed, 34 skipped, 3 xfailed in 103.89s (0:01:43) ============
C:\hostedtoolcache\windows\Python\3.14.1\x64-freethreaded\Lib\site-packages\coverage\inorout.py:521: CoverageWarning: Module tests/ was never imported. (module-not-imported); see https://coverage.readthedocs.io/en/7.12.0/messages.html#warning-module-not-imported
self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (7d87afe) to head (7d9ba6d). ⚠️ Report is 4 commits behind head on main.
Windows 3.14t x64 failed in test_run_in_trio_thread_ki (?) weirdly -- it didn't crash, pytest just suddenly exited. I don't think it's reproducible, but leaving this here for future search to find.
I'm also seeing this in the logs:\n\n =========== 857 passed, 34 skipped, 3 xfailed in 103.89s (0:01:43) ============\n C:\hostedtoolcache\windows\Python\3.14.1\x64-freethreaded\Lib\site-packages\coverage\inorout.py:521: CoverageWarning: Module tests/ was never imported. (module-not-imported); see https://coverage.readthedocs.io/en/7.12.0/messages.html#warning-module-not-imported\n self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")\nbut not sure how to address that :/
That seems related to the use of source and not source_pkgs like I mentioned in the other PR. Perhaps, I should look into it myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@webknjaz both issues you pointed out
I'm pretty sure this should fix both reasons for failing CI on main.
I'm also seeing this in the logs:
but not sure how to address that :/