-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff preview mode #3024
base: main
Are you sure you want to change the base?
Ruff preview mode #3024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd vote weakly against using ruff preview.
If you just want to run CI checks it's enough to push to a branch in this repo, without opening a PR. (or even better run tests locally ofc)
02bf8b1
to
4061f6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 121 121
Lines 17850 17847 -3
Branches 3208 3205 -3
==========================================
- Hits 17784 17781 -3
Misses 46 46
Partials 20 20
|
|
I feel like this is a bug, so astral-sh/ruff#13037 is tracking this.
This pull request enables ruff's preview mode.
Currently a work in progress, but I wanted to see if I've messed anything up in the unit tests.