Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff preview mode #3024

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

CoolCat467
Copy link
Member

This pull request enables ruff's preview mode.

Currently a work in progress, but I wanted to see if I've messed anything up in the unit tests.

@CoolCat467 CoolCat467 marked this pull request as draft June 28, 2024 04:35
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd vote weakly against using ruff preview.
If you just want to run CI checks it's enough to push to a branch in this repo, without opening a PR. (or even better run tests locally ofc)

src/trio/_tests/test_ssl.py Outdated Show resolved Hide resolved
src/trio/_tests/test_threads.py Outdated Show resolved Hide resolved
src/trio/_tests/test_unix_pipes.py Outdated Show resolved Hide resolved
src/trio/_tests/test_util.py Show resolved Hide resolved
src/trio/testing/_fake_net.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (6f614ec) to head (3eb8328).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files         121      121              
  Lines       17850    17847       -3     
  Branches     3208     3205       -3     
==========================================
- Hits        17784    17781       -3     
  Misses         46       46              
  Partials       20       20              
Files Coverage Δ
src/trio/_abc.py 100.00% <ø> (ø)
src/trio/_core/_entry_queue.py 100.00% <100.00%> (ø)
src/trio/_core/_run.py 99.38% <100.00%> (ø)
src/trio/_core/_tests/test_asyncgen.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_exceptiongroup_gc.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_guest_mode.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_instrumentation.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_io.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_ki.py 97.83% <100.00%> (ø)
src/trio/_core/_tests/test_local.py 100.00% <100.00%> (ø)
... and 40 more

@CoolCat467 CoolCat467 marked this pull request as ready for review August 4, 2024 07:54
@CoolCat467
Copy link
Member Author

hash argument fixes being merged in this should fix what caused previous ci runs to fail

@CoolCat467 CoolCat467 added the skip newsfragment Newsfragment is not required label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip newsfragment Newsfragment is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants